This project is read-only.
2
Vote

Bug Fixes and Enhancements, Forked

description

You can access a bunch of bug fixes and enhancements I put into this project at:

https://github.com/keithjjones/WhoisClient.NET

Feel free to incorporate my changes as needed.

comments

jsakamoto wrote Jan 19, 2016 at 12:24 AM

Thank you very much for your great contribution!

If you prefer, I would like to append you to owners of "WhoisClient.NET" (https://www.nuget.org/packages/WhoisClient.NET/) NuGet package.
How about this proposal?

jsakamoto wrote Jan 19, 2016 at 12:45 AM

P.S.
But, I hope change versioning method of your fork version, if you will accept my proposal.
I recomend "Semantic Versioning".

http://semver.org/

Summary:
  • format is "ver.{major}.{minor}.{build}"
  • Increment major when breaking change occured. (with reset minor and build)
  • Increment minor when add new feature, enhancement with keeping lower compatible. (and reset build)
  • Increment build when bug fix, change package meta data.
See also: https://github.com/csscomb/grunt-csscomb/issues/15

keithjjones wrote Jan 19, 2016 at 12:54 AM

Sure. The code is open source. Whatever works is fine with me. I needed the functionality so I added the changes. I hope they are helpful. It was much better than writing it from scratch!

I made a new NuGet package because I put together a larger NuGet package that I needed the changes for (WhoisGenie.NET) and I thought you may not be interested in outside contributions. I use the versioning that I do because I (try to) do a more "continuous integration" type of development and I use the date for that. I don't mind what you use.